Messages in this thread | | | Date | Mon, 30 Mar 2015 14:28:01 -0600 | From | Eric Blake <> | Subject | Re: [Qemu-devel] [PATCH v4 12/15] Add optional parameters to QMP command query-cpu-definitions |
| |
On 03/30/2015 08:28 AM, Michael Mueller wrote: > The patch adds optional parameters to the QMP command query-cpu-definitions. > Thus the signature of routine arch_query_cpu_definitions needs to be changed > for the stub function and all target implementations: > > target-arm > target-i386 > target-ppc > target-s390 > > Signed-off-by: Michael Mueller <mimu@linux.vnet.ibm.com> > ---
> +++ b/qapi-schema.json > @@ -2532,21 +2532,31 @@ > # > # @name: the name of the CPU definition > # > +# @default: #optional defines if cpu model is the default (since 2.4)
Reads poorly. How about:
# @default: #optional true if cpu model is the default, omitted if false (since 2.4)
> +# > +# @runnable: #optional defines if cpu model is runnable (since 2.4)
Similarly:
# @runnable: #optional true if cpu model is runnable, omitted if false (since 2.4)
> +# > # Since: 1.2.0 > ## > { 'type': 'CpuDefinitionInfo', > - 'data': { 'name': 'str' } } > + 'data': { 'name': 'str', '*is-default': 'bool', '*runnable': 'bool' } } > > ## > # @query-cpu-definitions: > # > # Return a list of supported virtual CPU definitions > # > +# @machine: #optional machine type (since 2.4) > +# > +# @accel: #optional accelerator id (since 2.4)
Maybe mention that these two fields are for filtering results.
-- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
[unhandled content-type:application/pgp-signature] | |