lkml.org 
[lkml]   [2015]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] perf, record: Add clockid parameter
On 3/30/15 1:32 PM, Peter Zijlstra wrote:

>>> --- a/tools/perf/builtin-record.c
>>> +++ b/tools/perf/builtin-record.c
>>> @@ -732,13 +732,16 @@ static const struct clockid_map clockids
>>> /* available for all events, NMI safe */
>>> CLOCKID_MAP("monotonic", CLOCK_MONOTONIC),
>>> CLOCKID_MAP("monotonic_raw", CLOCK_MONOTONIC_RAW),
>>> - CLOCKID_MAP("raw", CLOCK_MONOTONIC_RAW),
>>>
>>> /* available for some events */
>>> CLOCKID_MAP("realtime", CLOCK_REALTIME),
>>> CLOCKID_MAP("boottime", CLOCK_BOOTTIME),
>>> CLOCKID_MAP("tai", CLOCK_TAI),
>>>
>>> + /* available for the lazy */
>>> + CLOCKID_MAP("mono", CLOCK_MONOTONIC),
>>> + CLOCKID_MAP("raw", CLOCK_MONOTONIC_RAW),
>>> +
>>
>> how about this one as well:
>> CLOCKID_MAP("real", CLOCK_REALTIME),
>
> CLOCK_REALTIME is of limited usability because its not NMI safe.
>

sure, but you have the long version above. I was also suggesting the
shortcut version -- 5 fewer letters.


\
 
 \ /
  Last update: 2015-03-30 22:21    [W:0.062 / U:0.336 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site