Messages in this thread | | | Subject | Re: [RFC PATCH 08/11] IB/Verbs: Use management helper has_iwarp() for, iwarp-check | From | Doug Ledford <> | Date | Mon, 30 Mar 2015 12:13:00 -0400 |
| |
On Fri, 2015-03-27 at 16:47 +0100, Michael Wang wrote: > Introduce helper has_iwarp() to help us check if an IB device > support IWARP protocol.
This is a needless redirection. Just stick with the original rdma_transport_is_iwarp().
> Cc: Jason Gunthorpe <jgunthorpe@obsidianresearch.com> > Cc: Doug Ledford <dledford@redhat.com> > Cc: Ira Weiny <ira.weiny@intel.com> > Cc: Sean Hefty <sean.hefty@intel.com> > Signed-off-by: Michael Wang <yun.wang@profitbricks.com> > --- > include/rdma/ib_verbs.h | 13 +++++++++++++ > net/sunrpc/xprtrdma/svc_rdma_recvfrom.c | 2 +- > 2 files changed, 14 insertions(+), 1 deletion(-) > > diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h > index e796104..0ef9cd7 100644 > --- a/include/rdma/ib_verbs.h > +++ b/include/rdma/ib_verbs.h > @@ -1836,6 +1836,19 @@ static inline int has_mcast(struct ib_device *device) > } > > /** > + * has_iwarp - Check if a device support IWARP protocol. > + * > + * @device: Device to be checked > + * > + * Return 0 when a device has none port to support > + * IWARP protocol. > + */ > +static inline int has_iwarp(struct ib_device *device) > +{ > + return rdma_transport_is_iwarp(device); > +} > + > +/** > * cap_smi - Check if the port of device has the capability > * Subnet Management Interface. > * > diff --git a/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c b/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c > index a7b5891..48aeb5e 100644 > --- a/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c > +++ b/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c > @@ -118,7 +118,7 @@ static void rdma_build_arg_xdr(struct svc_rqst *rqstp, > > static int rdma_read_max_sge(struct svcxprt_rdma *xprt, int sge_count) > { > - if (rdma_transport_is_iwarp(xprt->sc_cm_id->device)) > + if (has_iwarp(xprt->sc_cm_id->device)) > return 1; > else > return min_t(int, sge_count, xprt->sc_max_sge);
-- Doug Ledford <dledford@redhat.com> GPG KeyID: 0E572FDD
[unhandled content-type:application/pgp-signature] | |