lkml.org 
[lkml]   [2015]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Subject[PATCH v4 0/3] Two printf fixes
    Date
    Both %pE and %ph are unusable in kasprintf(), since the occurrence of
    either will trigger an oops during the first vsnprintf call where
    kasprintf tries to find the correct size to allocate. These oopses
    could be papered over with somewhat smaller patches than these, but
    then the return value from vsnprintf would still not reflect the
    actual size needed. For %pE, this requires a change of semantics of
    string_escape_mem and hence an annoyingly large diffstat.

    v4: Also update fs/proc/array.c, factor overflow test into separate
    helper, minor stylistic changes.

    Changed in v3:

    * Add Andy's ack to 1/3.

    * Ensure that string_escape_mem doesn't output partial escape
    sequences after 2/3, while still preparing for it to do exactly that
    in 3/3.

    * Leave the return value of string_escape_mem as int.

    v2: Suggestions from Andy Shevchenko:

    * Simpler fix of hex_string().

    * The string_escape_mem change is split in two, 2/3 updating the
    internal helpers and 3/3 then changing the external interface.


    Rasmus Villemoes (3):
    lib/vsprintf.c: Fix potential NULL deref in hex_string
    lib/string_helpers.c: Refactor string_escape_mem
    lib/string_helpers.c: Change semantics of string_escape_mem

    fs/proc/array.c | 4 +-
    include/linux/string_helpers.h | 8 +-
    lib/string_helpers.c | 193 +++++++++++++++++------------------------
    lib/test-string_helpers.c | 38 ++++----
    lib/vsprintf.c | 24 +++--
    net/sunrpc/cache.c | 8 +-
    6 files changed, 127 insertions(+), 148 deletions(-)

    --
    2.1.3



    \
     
     \ /
      Last update: 2015-03-04 00:41    [W:3.167 / U:0.408 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site