Messages in this thread | | | Subject | Re: [PATCH net-next 01/14] etherdevice: Add eth_<foo>_addr CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS code | From | Joe Perches <> | Date | Tue, 03 Mar 2015 11:07:51 -0800 |
| |
On Tue, 2015-03-03 at 10:42 -0800, Eric Dumazet wrote: > On Tue, 2015-03-03 at 10:25 -0800, Joe Perches wrote: > > > At least for arm gcc 4.6.3, it emits different code > > for net/l2tp/l2tp_eth.o > > Then it looks like arm gcc or arm linux memset() should be improved.
Perhaps you can take that up with the gcc folk.
I think it appropriate to improve the actual emitted code for the compiler I use.
(it seems this code isn't fast-path anywhere though)
> Tracking all memset(x, y, 6) and replace them by some custom version > seems not very generic to me, when something better can be done.
There's the same argument for the ether_addr_equal and ether_addr_copy functions.
iow: memcmp, memcpy too
cheers, Joe
| |