Messages in this thread | | | Date | Tue, 3 Mar 2015 08:43:14 -0800 | From | Darren Hart <> | Subject | Re: [RFT PATCH v3 2/2] compal-laptop: Check return value of power_supply_register |
| |
On Fri, Feb 20, 2015 at 02:13:35PM +0100, Krzysztof Kozlowski wrote: > The return value of power_supply_register() call was not checked and > even on error probe() function returned 0. If registering failed then > during unbind the driver tried to unregister power supply which was not > actually registered. > > This could lead to memory corruption because power_supply_unregister() > unconditionally cleans up given power supply. > > Fix this by checking return status of power_supply_register() call. In > case of failure, clean up sysfs entries and fail the probe. > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > Fixes: 9be0fcb5ed46 ("compal-laptop: add JHL90, battery & hwmon interface") > Cc: <stable@vger.kernel.org>
Acked-by: Darren Hart <dvhart@linux.intel.com>
-- Darren Hart Intel Open Source Technology Center
| |