Messages in this thread | | | Date | Mon, 30 Mar 2015 11:47:01 +0900 | From | Namhyung Kim <> | Subject | Re: [RFC][PATCH 05/10] f2fs: Export the enums in the tracepoints to userspace |
| |
On Fri, Mar 27, 2015 at 05:37:09PM -0400, Steven Rostedt wrote: > From: "Steven Rostedt (Red Hat)" <rostedt@goodmis.org> > > The tracepoints that use __print_symbolic() use enums as the value > to convert to strings. Unfortunately, the format files for these > tracepoints show the enum name and not their value. This causes some > userspace tools not to know how to convert __print_symbolic() to > their strings. > > Add TRACE_DEFINE_ENUM() macros to export the enums used to userspace > to let those tools know what those enum values are. > > Cc: Namjae Jeon <namjae.jeon@samsung.com> > Cc: Pankaj Kumar <pankaj.km@samsung.com> > Cc: Jaegeuk Kim <jaegeuk.kim@samsung.com>
AFAIK Jaegeuk's samsung email is not valid anymore..
$ grep -a Jaegeuk MAINTAINERS M: Jaegeuk Kim <jaegeuk@kernel.org>
Thanks, Namhyung
> Signed-off-by: Steven Rostedt <rostedt@goodmis.org> > --- > include/trace/events/f2fs.h | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/include/trace/events/f2fs.h b/include/trace/events/f2fs.h > index 5422dbfaf97d..a0074dd8d140 100644 > --- a/include/trace/events/f2fs.h > +++ b/include/trace/events/f2fs.h > @@ -9,6 +9,27 @@ > #define show_dev(entry) MAJOR(entry->dev), MINOR(entry->dev) > #define show_dev_ino(entry) show_dev(entry), (unsigned long)entry->ino > > +TRACE_DEFINE_ENUM(NODE); > +TRACE_DEFINE_ENUM(DATA); > +TRACE_DEFINE_ENUM(META_FLUSH); > +TRACE_DEFINE_ENUM(CURSEG_HOT_DATA); > +TRACE_DEFINE_ENUM(CURSEG_WARM_DATA); > +TRACE_DEFINE_ENUM(CURSEG_COLD_DATA); > +TRACE_DEFINE_ENUM(CURSEG_HOT_NODE); > +TRACE_DEFINE_ENUM(CURSEG_WARM_NODE); > +TRACE_DEFINE_ENUM(CURSEG_COLD_NODE); > +TRACE_DEFINE_ENUM(NO_CHECK_TYPE); > +TRACE_DEFINE_ENUM(GC_GREEDY); > +TRACE_DEFINE_ENUM(GC_CB); > +TRACE_DEFINE_ENUM(__REQ_RAHEAD); > +TRACE_DEFINE_ENUM(__REQ_WRITE); > +TRACE_DEFINE_ENUM(__REQ_SYNC); > +TRACE_DEFINE_ENUM(__REQ_NOIDLE); > +TRACE_DEFINE_ENUM(__REQ_FLUSH); > +TRACE_DEFINE_ENUM(__REQ_FUA); > +TRACE_DEFINE_ENUM(__REQ_PRIO); > +TRACE_DEFINE_ENUM(__REQ_META); > + > #define show_block_type(type) \ > __print_symbolic(type, \ > { NODE, "NODE" }, \ > -- > 2.1.4 > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
| |