lkml.org 
[lkml]   [2015]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH net-next] wireless: Use bool function returns of true/false instead of 1/0
From
Date
On Sun, 2015-03-29 at 20:46 -0500, Larry Finger wrote:
> On 03/29/2015 08:29 PM, Joe Perches wrote:
> > Use bool constants as the return values instead of 1 and 0.
> >
> > Signed-off-by: Joe Perches <joe@perches.com>
> > ---
> >> To be honest I'd might rather get bunches of these, there has to be a ton
> >> of them, than a slow trickle of one every few weeks/days.
> >
> > There aren't too many here either...
> >
> > drivers/net/wireless/b43/dma.c | 12 ++++++------
> > drivers/net/wireless/b43legacy/dma.c | 6 +++---
> > drivers/net/wireless/b43legacy/rfkill.c | 8 ++++----
> > drivers/net/wireless/brcm80211/brcmsmac/phy/phy_cmn.c | 2 +-
> > drivers/net/wireless/brcm80211/brcmsmac/phy/phy_lcn.c | 2 +-
> > drivers/net/wireless/iwlwifi/iwl-config.h | 4 ++--
> > 6 files changed, 17 insertions(+), 17 deletions(-)
>
> Please split these into separate patches for each driver. That way it will be
> possible to search 'git log' for the contributions to each driver. Otherwise,
> the patches are OK.

It's still possible.

git log <directory> shows the individual patches.




\
 
 \ /
  Last update: 2015-03-30 04:21    [W:0.045 / U:0.516 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site