lkml.org 
[lkml]   [2015]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3 5/7] dmaengine: omap-dma: Take DMA request number from DT if it is available
    On Fri, Mar 27, 2015 at 02:26:51PM +0200, Peter Ujfalusi wrote:
    > + if (!pdev->dev.of_node || of_property_read_u32(pdev->dev.of_node,
    > + "dma-requests",
    > + &od->dma_requests)) {
    > + dev_info(&pdev->dev,
    > + "Missing dma-requests property, using %u.\n",
    > + OMAP_SDMA_REQUESTS);
    > + od->dma_requests = OMAP_SDMA_REQUESTS;
    > + }

    Are all OMAPs including OMAP1 being converted to DT? If not, don't
    introduce noisy printks for which a platform can't do anything about.
    Think about this please - if there's no of_node, then why complain
    about a missing OF property?

    --
    FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
    according to speedtest.net.


    \
     
     \ /
      Last update: 2015-03-27 21:41    [W:5.792 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site