Messages in this thread | | | Date | Fri, 27 Mar 2015 20:38:58 +0100 | From | "Luis R. Rodriguez" <> | Subject | Re: [PATCH v1 09/47] vidoe: fbdev: atyfb: remove and fix MTRR MMIO "hole" work around |
| |
On Fri, Mar 27, 2015 at 10:37:04AM +0200, Ville Syrjälä wrote: > On Sat, Mar 21, 2015 at 11:15:14AM +0200, Ville Syrjälä wrote: > > On Fri, Mar 20, 2015 at 04:17:59PM -0700, Luis R. Rodriguez wrote: > > > diff --git a/drivers/video/fbdev/aty/atyfb_base.c b/drivers/video/fbdev/aty/atyfb_base.c > > > index 8025624..8875e56 100644 > > > --- a/drivers/video/fbdev/aty/atyfb_base.c > > > +++ b/drivers/video/fbdev/aty/atyfb_base.c > > > @@ -2630,21 +2630,10 @@ static int aty_init(struct fb_info *info) > > > > > > #ifdef CONFIG_MTRR > > > par->mtrr_aper = -1; > > > - par->mtrr_reg = -1; > > > if (!nomtrr) { > > > - /* Cover the whole resource. */ > > > - par->mtrr_aper = mtrr_add(par->res_start, par->res_size, > > > + par->mtrr_aper = mtrr_add(info->fix.smem_start, > > > + info->fix.smem_len, > > > MTRR_TYPE_WRCOMB, 1); > > > > MTRRs need power of two size, so how is this supposed to work? > > Still waiting for an answer...
Sorry was in the desert for a bit, I'm back now.
Luis
| |