lkml.org 
[lkml]   [2015]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] x86: add a is_e820_ram() helper
On Thu, Mar 26, 2015 at 03:59:28PM -0700, Yinghai Lu wrote:
> What do you want to get here?
>
> You did not modify memblock_x86_fill() to treat
> E820_PRAM as E820_RAM, so memblock will not have any
> entry for E820_PRAM, so you do not need to call memblock_reserve
> there.
>
> And the same time, init_memory_mapping() will call
> init_range_memory_mapping/for_each_mem_pfn_range() to
> set kernel mapping for memory range in memblock only.
> So here calling init_memory_mapping will not do anything.
> then just drop calling to that init_memory_mapping.
> --- so will not kernel mapping pmem, is that what you intended to have?

I think the intent of the old Intel code was to indeed map the pmem
into KVA space. That got broken when I forward ported it to use
memblocks. However the current pmem infrastructure doesn't need the
KVA mapping, so I can remove it for now.

However we have heated discussions about how to do I/O to pmem, and
KVA mapping is one of the options. If we got with that option I might
bring this code back in a fixed up version.


\
 
 \ /
  Last update: 2015-03-27 09:21    [W:0.171 / U:0.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site