lkml.org 
[lkml]   [2015]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] SQUASHME: Streamline pmem.c
From
Date
On Thu, 2015-03-26 at 19:02 +0200, Boaz Harrosh wrote:
> Christoph why did you choose the fat and ugly version of
> pmem.c beats me. Anyway, here are the cleanups you need on
> top of your pmem patch.
>
> Among other it does:
> * Remove getgeo. It is not needed for modern fdisk and was never
> needed for libgparted and cfdisk.
>
> * remove 89 lines of code to do a single memcpy. The reason
> this was so in brd (done badly BTW) is because destination
> memory is page-by-page based. With pmem we have the destination
> contiguous so we can do any size, in one go.
>
> * Remove SECTOR_SHIFT. It is defined in 6 other places
> in the Kernel. I do not like a new one. 9 is used through
> out, including block core. I do not like pmem to blasphemy
> more than needed.
>
> * More style stuff ...
>
> Please squash into your initial submission
>
> Signed-off-by: Boaz Harrosh <boaz@plexistor.com>

I agree with Christoph's comments, but overall I think these changes are
great. Please send out as a series & you can add:

Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>



\
 
 \ /
  Last update: 2015-03-27 00:01    [W:0.259 / U:0.428 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site