Messages in this thread | | | Subject | Re: [PATCH V2] sched: Improve load balancing in the presence of idle CPUs | From | Jason Low <> | Date | Thu, 26 Mar 2015 10:03:20 -0700 |
| |
On Thu, 2015-03-26 at 18:32 +0530, Preeti U Murthy wrote: > kernel/sched/fair.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index bcfe320..8b6d0d5 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -7660,14 +7660,16 @@ static void run_rebalance_domains(struct softirq_action *h) > enum cpu_idle_type idle = this_rq->idle_balance ? > CPU_IDLE : CPU_NOT_IDLE; > > - rebalance_domains(this_rq, idle); > - > /* > * If this cpu has a pending nohz_balance_kick, then do the > * balancing on behalf of the other idle cpus whose ticks are > - * stopped. > + * stopped. Do nohz_idle_balance *before* rebalance_domains to > + * give the idle cpus a chance to load balance. Else we may > + * load balance only within the local sched_domain hierarchy > + * and abort nohz_idle_balance altogether if we pull some load. > */ > nohz_idle_balance(this_rq, idle); > + rebalance_domains(this_rq, idle);
Reviewed-by: Jason Low <jason.low2@hp.com>
| |