lkml.org 
[lkml]   [2015]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCHv5 09/11] fbdev: ssd1307fb: Add module parameter to set the initial contrast
    Am Tue, 24 Mar 2015 15:16:36 -0700
    schrieb Maxime Ripard <maxime.ripard@free-electrons.com>:

    > On Tue, Mar 24, 2015 at 10:23:56PM +0100, Thomas Niederprüm wrote:
    > > This patch adds the module parameter "contrast" to determine the
    > > contrast value that is used to initialize the display. This
    > > setting applies to all instances of the driver.
    > >
    > > Signed-off-by: Thomas Niederprüm <niederp@physik.uni-kl.de>
    >
    > Do we still need this patch given that the next one is doing the exact
    > same thing?
    I was kind of expecting this objection. I added this module parameter
    since it suits my use case where I always run the display at the lowest
    possible contrast. With this module parameter I can specify this need
    at module load time and I do not need udev or to touch the backlight
    controls manually every time the driver is loaded. I see that this is
    probably a (too) weak argument, so if nobody complains I will remove
    this patch for the next round.

    Thomas


    \
     
     \ /
      Last update: 2015-03-25 23:21    [W:3.987 / U:0.232 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site