lkml.org 
[lkml]   [2015]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v1 45/47] video: fbdev: geode gxfb: use ioremap_wc() for framebuffer
    Date
    From: "Luis R. Rodriguez" <mcgrof@suse.com>

    The driver doesn't use mtrr_add() or arch_phys_wc_add() but
    since we know the framebuffer is isolated already on an
    ioremap() we can take advantage of write combining for
    performance where possible.

    In this case there are a few motivations for this:

    a) Take advantage of PAT when available

    b) Help with the goal of eventually using _PAGE_CACHE_UC over
    _PAGE_CACHE_UC_MINUS on x86 on ioremap_nocache() (de33c442e)

    Cc: Suresh Siddha <suresh.b.siddha@intel.com>
    Cc: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
    Cc: Ingo Molnar <mingo@elte.hu>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: Juergen Gross <jgross@suse.com>
    Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
    Cc: Andy Lutomirski <luto@amacapital.net>
    Cc: Dave Airlie <airlied@redhat.com>
    Cc: Antonino Daplas <adaplas@gmail.com>
    Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
    Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
    Cc: linux-fbdev@vger.kernel.org
    Cc: linux-kernel@vger.kernel.org
    Signed-off-by: Luis R. Rodriguez <mcgrof@suse.com>
    ---
    drivers/video/fbdev/geode/gxfb_core.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/video/fbdev/geode/gxfb_core.c b/drivers/video/fbdev/geode/gxfb_core.c
    index 124d7c7..ec9fc9a 100644
    --- a/drivers/video/fbdev/geode/gxfb_core.c
    +++ b/drivers/video/fbdev/geode/gxfb_core.c
    @@ -263,7 +263,8 @@ static int gxfb_map_video_memory(struct fb_info *info, struct pci_dev *dev)

    info->fix.smem_start = pci_resource_start(dev, 0);
    info->fix.smem_len = vram ? vram : gx_frame_buffer_size();
    - info->screen_base = ioremap(info->fix.smem_start, info->fix.smem_len);
    + info->screen_base = ioremap_wc(info->fix.smem_start,
    + info->fix.smem_len);
    if (!info->screen_base)
    return -ENOMEM;

    --
    2.3.2.209.gd67f9d5.dirty


    \
     
     \ /
      Last update: 2015-03-21 02:21    [W:4.162 / U:0.536 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site