Messages in this thread | | | Date | Mon, 2 Mar 2015 12:34:30 -0800 (PST) | From | David Rientjes <> | Subject | Re: [RFC 1/4] mm: Clarify __GFP_NOFAIL deprecation status |
| |
On Mon, 2 Mar 2015, Michal Hocko wrote:
> diff --git a/include/linux/gfp.h b/include/linux/gfp.h > index 51bd1e72a917..0cf9c2772988 100644 > --- a/include/linux/gfp.h > +++ b/include/linux/gfp.h > @@ -57,8 +57,10 @@ struct vm_area_struct; > * _might_ fail. This depends upon the particular VM implementation. > * > * __GFP_NOFAIL: The VM implementation _must_ retry infinitely: the caller > - * cannot handle allocation failures. This modifier is deprecated and no new > - * users should be added. > + * cannot handle allocation failures. New users should be evaluated carefuly > + * (and the flag should be used only when there is no reasonable failure policy) > + * but it is definitely preferable to use the flag rather than opencode endless > + * loop around allocator. > * > * __GFP_NORETRY: The VM implementation must not retry indefinitely. > *
s/carefuly/carefully/
Acked-by: David Rientjes <rientjes@google.com>
| |