Messages in this thread | | | Date | Mon, 2 Mar 2015 11:46:57 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH] Staging: rtl8188eu: fix coding style errors |
| |
On Fri, Feb 27, 2015 at 10:58:28AM -0600, Larry Finger wrote: > On 02/27/2015 10:44 AM, Matteo Semenzato wrote: > >From: Matteo Semenzato <mattew8898@gmail.com> > > > >This patch fixes the following errors: > >ERROR: space prohibited before that ',' (ctx:WxW) > >ERROR: space prohibited before that ',' (ctx:WxW) > >ERROR: switch and case should be at the same indent > > > >Signed-off-by: Matteo Semenzato <mattew8898@gmail.com> > > I appreciate your efforts, but you are not improving the source. > Running scripts/checkpatch.pl against your patch results in the > following summary: > > total: 60 errors, 32 warnings, 352 lines checked > > You have fixed 60 errors, and introduced 60 new ones. :(
That's weird. I only get the 32 warnings. Those are all long line warnings which were there in the original code as well.
regards, dan carpenter
| |