lkml.org 
[lkml]   [2015]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v4 13/15] ASoC: codec/dw-hdmi-audio: add codec driver for dw hdmi audio


    在 2015/3/2 17:15, Paul Bolle 写道:
    > On Sat, 2015-02-28 at 21:59 -0500, Yakir Yang wrote:
    >> --- /dev/null
    >> +++ b/sound/soc/codecs/dw-hdmi-audio.c
    >> @@ -0,0 +1,379 @@
    >> +/*
    >> + * dw-hdmi-codec.c
    > Doesn't match the filename. Is this line needed?

    Thanks, this comment are good for read, and seems others codec driver
    also content this comment,
    so I think we can keep this comment.
    I will correct the file name it in next version.

    Thanks for you reply :)
    >
    >> + * DesignerWare ALSA SoC DAI driver for DW HDMI audio.
    >> + * Copyright (c) 2014, CORPORATION. All rights reserved.
    >> + * Authors: Yakir Yang <ykk@rock-chips.com>
    >> + *
    >> + * This program is free software; you can redistribute it and/or modify it
    >> + * under the terms and conditions of the GNU General Public License,
    >> + * version 2, as published by the Free Software Foundation.
    >> + *
    >> + * This program is distributed in the hope it will be useful, but WITHOUT
    >> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
    >> + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
    >> + * more details.
    >> + *
    >> + * You should have received a copy of the GNU General Public License
    >> + * along with this program. If not, see <http://www.gnu.org/licenses/>.*
    >> + *
    >> + */
    > This states that the license is plain GPL v2.
    >
    > (Missing empty line here.)

    Okay, thanks, correct it in next version.

    Thanks :)
    >> +#include <linux/init.h>
    > [...]
    >
    >> +MODULE_LICENSE("GPL");
    > So you probably want
    > MODULE_LICENSE("GPL v2");
    >
    > here.
    Okay, thanks, correct it in next version.

    Thanks :)

    Yakir Yang
    Best regards.

    >
    > Paul Bolle
    >
    >
    >
    >




    \
     
     \ /
      Last update: 2015-03-02 12:41    [W:3.550 / U:0.512 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site