Messages in this thread | | | Subject | Re: [PATCH net-next 02/14] ethernet: Use eth_<foo>_addr instead of memset | From | Jeff Kirsher <> | Date | Mon, 02 Mar 2015 20:09:34 -0800 |
| |
On Mon, 2015-03-02 at 19:54 -0800, Joe Perches wrote: > Use the built-in function instead of memset. > > Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> for the changes to Intel's ixgbe driver...
> --- > drivers/net/ethernet/amd/pcnet32.c | 2 +- > drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c | 2 +- > drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 6 +++--- > drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c | 2 +- > drivers/net/ethernet/cisco/enic/enic_main.c | 8 ++++---- > drivers/net/ethernet/emulex/benet/be_cmds.c | 2 +- > drivers/net/ethernet/emulex/benet/be_main.c | 2 +- > drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 4 ++-- > drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 4 ++-- > drivers/net/ethernet/mellanox/mlx4/en_selftest.c | 2 +- > drivers/net/ethernet/micrel/ksz884x.c | 2 +- > drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c | 2 +- > drivers/net/ethernet/qlogic/qlge/qlge_main.c | 2 +- > drivers/net/ethernet/smsc/smsc911x.c | 2 +- > drivers/net/ethernet/ti/netcp_core.c | 2 +- > drivers/net/ethernet/toshiba/ps3_gelic_wireless.c | 4 ++-- > drivers/net/ethernet/xscale/ixp4xx_eth.c | 2 +- > 17 files changed, 25 insertions(+), 25 deletions(-) ... > diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c > index 70cc4c5..903664f 100644 > --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c > +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c > @@ -3924,7 +3924,7 @@ static void ixgbe_flush_sw_mac_table(struct ixgbe_adapter *adapter) > for (i = 0; i < hw->mac.num_rar_entries; i++) { > adapter->mac_table[i].state |= IXGBE_MAC_STATE_MODIFIED; > adapter->mac_table[i].state &= ~IXGBE_MAC_STATE_IN_USE; > - memset(adapter->mac_table[i].addr, 0, ETH_ALEN); > + eth_zero_addr(adapter->mac_table[i].addr); > adapter->mac_table[i].queue = 0; > } > ixgbe_sync_mac_table(adapter); > @@ -3992,7 +3992,7 @@ int ixgbe_del_mac_filter(struct ixgbe_adapter *adapter, u8 *addr, u16 queue) > adapter->mac_table[i].queue == queue) { > adapter->mac_table[i].state |= IXGBE_MAC_STATE_MODIFIED; > adapter->mac_table[i].state &= ~IXGBE_MAC_STATE_IN_USE; > - memset(adapter->mac_table[i].addr, 0, ETH_ALEN); > + eth_zero_addr(adapter->mac_table[i].addr); > adapter->mac_table[i].queue = 0; > ixgbe_sync_mac_table(adapter); > return 0;
[unhandled content-type:application/pgp-signature] | |