lkml.org 
[lkml]   [2015]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 09/20] perf tools: Remove annoying extra message from the features build
    Date
    From: Ingo Molnar <mingo@kernel.org>

    This message:

    Makefile:153: The path 'python-config' is not executable.

    Appears on every perf build that does not have a sufficient python
    environment installed. It's really just an internal detail of python
    configuration pass and users should not see it - and it's pretty
    meaningless to them in any case because the message is not very helpful.
    (So it's not executable. Why does that matter? What can the user do
    about it?)

    Remove the warning, the missing python feature warning is sufficient:

    config/Makefile:566: No python-config tool was found
    config/Makefile:566: Python support will not be built

    although even that one isn't very helpful to users: so no Python support
    will be built, what can the user do to fix that? Most other such
    warnings give package install suggestions.

    Signed-off-by: Ingo Molnar <mingo@kernel.org>
    Cc: David Ahern <david.ahern@oracle.com>
    Cc: Jiri Olsa <jolsa@redhat.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Link: http://lkml.kernel.org/r/20150228081750.GA31887@gmail.com
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    ---
    tools/perf/config/utilities.mak | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/tools/perf/config/utilities.mak b/tools/perf/config/utilities.mak
    index 7076a62d0ff7..c16ce833079c 100644
    --- a/tools/perf/config/utilities.mak
    +++ b/tools/perf/config/utilities.mak
    @@ -175,6 +175,5 @@ _ge-abspath = $(if $(is-executable),$(1))
    define get-executable-or-default
    $(if $($(1)),$(call _ge_attempt,$($(1)),$(1)),$(call _ge_attempt,$(2)))
    endef
    -_ge_attempt = $(if $(get-executable),$(get-executable),$(_gea_warn)$(call _gea_err,$(2)))
    -_gea_warn = $(warning The path '$(1)' is not executable.)
    +_ge_attempt = $(if $(get-executable),$(get-executable),$(call _gea_err,$(2)))
    _gea_err = $(if $(1),$(error Please set '$(1)' appropriately))
    --
    1.9.3


    \
     
     \ /
      Last update: 2015-03-03 05:01    [W:4.089 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site