lkml.org 
[lkml]   [2015]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [2/9] powerpc/hv24x7: Remove unnecessary parameter
    Date
    On Tue, 2015-17-02 at 22:00:27 UTC, Sukadev Bhattiprolu wrote:
    > Use pr_notice_ratelimited() to log error messages and remove
    > the 'success_expected' parameter.

    I don't understand how this is equivalent?

    The current code uses success_expected to indicate that once it's done the
    request once and found that it works, it then expects the request to continue
    working, and if it doesn't then that is an error.

    Using pr_ratelimited() will do the opposite, ie. the first failure will print a
    message, but that may not really indicate an error, it may just be a badly
    configured request.

    Or at least that's how I understand it, please convince me I'm wrong :)

    cheers


    \
     
     \ /
      Last update: 2015-03-17 01:21    [W:3.828 / U:0.500 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site