Messages in this thread | | | Date | Sat, 14 Mar 2015 16:13:08 +0100 | From | Oleg Nesterov <> | Subject | [PATCH 0/1] x86/cpu: kill eager_fpu_init_bp() |
| |
On 03/14, Borislav Petkov wrote: > > On Fri, Mar 13, 2015 at 07:26:56PM +0100, Oleg Nesterov wrote: > > Hello. > > > > This patch is "out of order" a bit, but since Borislav mentioned this > > during review... > > > > And I was going to send the 2nd one (below), but it turns out that > > __init_refok is not discarded? So is there any way to do > > > > void __init init_function(); > > > > void non_init_func() > > { > > if (can_only_be_true_before_free_initmem) > > init_function(); > > } > > > > and avoid the warning?
It turns out I _completely_ misunderstood __init_refok.
> Actually, I was wondering if we could be even more radical and do > the boot cpu-specific stuff only in the BSP boot path.
Yes, yes, agreed. This needs more changes, but imo this would be a nice cleanup.
Still. I think it makes sense to kill eager_fpu_init_bp() right now, this won'r complicate the mentioned cleanups.
On top of "x86/fpu: don't allocate fpu->state for swapper/0".
Oleg.
| |