lkml.org 
[lkml]   [2015]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: Bad rpath in cpupower with 4.0-rcX
Date
On Tuesday, March 10, 2015 08:33:54 AM Josh Boyer wrote:
> On Fri, Mar 6, 2015 at 8:47 AM, Josh Boyer <jwboyer@fedoraproject.org> wrote:
> > Hi All,
> >
> > Commit 5c1de006e8e66 (cpupower Makefile change to help run the tool
> > without 'make install') added an rpath to the cpupower binary. From
> > what I can understand, this is to make it easier to run cpupower from
> > the local build directory without having to run make install. It does
> > accomplish that, but it also leaves the binary with the rpath in it
> > which is considered bad practice. It also causes cpupower to fail in
> > rpmbuild with the following error:
> >
> > ERROR 0004: file '/usr/bin/cpupower' contains an insecure rpath './'
> > in [./]
> > error: Bad exit status from /var/tmp/rpm-tmp.A6u26r (%install)
> > Bad exit status from /var/tmp/rpm-tmp.A6u26r (%install)
> >
> > I understand the want for eased development, but couldn't people just
> > set LD_LIBRARY_PATH instead?
>
> No comments on this? Should I just send a revert patch instead?

You can do that.


--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.


\
 
 \ /
  Last update: 2015-03-10 23:41    [W:0.052 / U:0.640 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site