Messages in this thread | | | Date | Mon, 9 Feb 2015 09:52:39 +0100 | From | Maxime Ripard <> | Subject | Re: [PATCH 7/8] fbdev: ssd1307fb: Add sysfs handles to expose contrast and dim setting to userspace. |
| |
On Sat, Feb 07, 2015 at 05:42:44PM +0100, Thomas Niederprüm wrote: > > > +static struct device_attribute device_attrs[] = { > > > + __ATTR(contrast, S_IRUGO|S_IWUSR, show_contrast, > > > store_contrast), > > > + __ATTR(dim, S_IRUGO|S_IWUSR, show_dim, store_dim), > > > + > > > +}; > > > + > > > > I would have thought this was something accessible through the > > framebuffer ioctl. > > > > Apparently it's not, at least for the contrast, so maybe it should be > > added there, instead of doing it for a single driver? > > I think the contrast setting for an OLED display is much like the > backlight setting for LCD panel. Since there is also no ioctl to set > the backlight of an LCD I wonder if the contrast of an OLED should have > one.
It's too much of framebuffer interface debate for me here. Tomi?
Maxime
-- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com [unhandled content-type:application/pgp-signature] | |