lkml.org 
[lkml]   [2015]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/4] SCSI-QLA4...: Less function calls in qla4xxx_is_session_exists() after error detection
> 1)  People gloss over initializers without reading them.

I would find such a habit strange.


> You shouldn't put complicated code in initializers.

Does the affected memory allocation fall into such a category?


> 2) It means you have to put a line of separation between the allocation
> and the NULL check, but they should be next to each other.

Would you like to extend the Linux coding style documentation?

Regards,
Markus


\
 
 \ /
  Last update: 2015-02-07 18:41    [W:0.812 / U:1.924 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site