Messages in this thread | | | Date | Thu, 5 Feb 2015 16:41:39 +0800 | From | Dave Young <> | Subject | Re: [PATCH] efi, x86: Add a "debug" option to the efi= cmdline |
| |
On 02/05/15 at 09:11am, Borislav Petkov wrote: > On Thu, Feb 05, 2015 at 11:18:46AM +0800, Dave Young wrote: > > > diff --git a/include/linux/efi.h b/include/linux/efi.h > > > index 0238d612750e..14cec75d7e74 100644 > > > --- a/include/linux/efi.h > > > +++ b/include/linux/efi.h > > > @@ -940,6 +940,7 @@ extern int __init efi_setup_pcdp_console(char *); > > > #define EFI_64BIT 5 /* Is the firmware 64-bit? */ > > > #define EFI_PARAVIRT 6 /* Access is via a paravirt interface */ > > > #define EFI_ARCH_1 7 /* First arch-specific bit */ > > > +#define EFI_DBG 8 /* Print additional debug info at runtime */ > > > > Boris, a nickpick about alignment of the second column.. > > This is due to how diffs show tabs. See EFI_PARAVIRT above, it appears > misaligned too. If you switch to list mode in vim, for example, it'll > show you how many tabs are being used: > > #define EFI_PARAVIRT^I^I6^I/* Access is via a paravirt interface */$ > #define EFI_ARCH_1^I^I7^I/* First arch-specific bit */$ > #define EFI_DBG^I^I^I8^I/* Print additional debug info at runtime */$ > > and EFI_DBG has an additional tab. However, the vertical alignment is > correct. You can apply the patch and see for yourself :-)
Interesting, you are right :)
Acked-by: Dave Young <dyoung@redhat.com>
Thanks Dave
| |