Messages in this thread | | | Subject | Re: [PATCH] kernel.h: Remove ancient __FUNCTION__ hack | From | Joe Perches <> | Date | Wed, 04 Feb 2015 14:05:15 -0800 |
| |
On Wed, 2015-02-04 at 23:01 +0100, Rasmus Villemoes wrote: > On Wed, Feb 04 2015, Joe Perches <joe@perches.com> wrote: > > > On Wed, 2015-02-04 at 21:55 +0100, Rasmus Villemoes wrote: > >> On Wed, Feb 04 2015, Joe Perches <joe@perches.com> wrote: > >> > >> > On Wed, 2015-02-04 at 10:48 +0100, Rasmus Villemoes wrote: > >> >> __FUNCTION__ hasn't been treated as a string literal since gcc 3.4, so > >> >> this only helps people who only test-compile using 3.3 > >> >> (compiler-gcc3.h barks at anything older than that). Besides, there > >> >> are almost no occurrences of __FUNCTION__ left in the tree. > >> > > >> > The remaining uses of __FUNCTION__ need converting first. > >> > >> Why? __FUNCTION__ is recognized just fine by gcc as an alias for __func__. > > > > And icc and clang and ...? > > clang yes, icc probably (from quick googling).
Cool, but it does seem safer/more conservative to me to convert the last 3 uses before doing this.
| |