Messages in this thread Patch in this message | | | Date | Wed, 04 Feb 2015 14:50:56 -0500 | From | Steven Rostedt <> | Subject | [for-next][PATCH 9/9] ktest: Place quotes around item variable |
| |
From: "Steven Rostedt (Red Hat)" <rostedt@goodmis.org>
Seems that some of the new console logic causes doprint to possibly get evaluated. When printing a commit message that contains parenthesis, it fails with a shell parsing error.
This gets fixed when we add quotes around the $item variable, and prevent it from being evaluated by any shell commands.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org> --- tools/testing/ktest/ktest.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/ktest/ktest.pl b/tools/testing/ktest/ktest.pl index 840803b3cd41..d08e214ec6e7 100755 --- a/tools/testing/ktest/ktest.pl +++ b/tools/testing/ktest/ktest.pl @@ -3447,7 +3447,7 @@ sub patchcheck { my $sha1 = $item; $sha1 =~ s/^([[:xdigit:]]+).*/$1/; - doprint "\nProcessing commit $item\n\n"; + doprint "\nProcessing commit \"$item\"\n\n"; run_command "git checkout $sha1" or die "Failed to checkout $sha1"; -- 2.1.4
| |