lkml.org 
[lkml]   [2015]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH] net: ep93xx_eth: Delete unnecessary checks before the function call "kfree"
    Date
    On Wednesday, February 04, 2015 8:01 AM, Markus Elfring wrote:
    > The kfree() function tests whether its argument is NULL and then
    > returns immediately. Thus the test around the call is not needed.
    >
    > This issue was detected by using the Coccinelle software.
    >
    > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    > ---
    > drivers/net/ethernet/cirrus/ep93xx_eth.c | 6 ++----
    > 1 file changed, 2 insertions(+), 4 deletions(-)
    >
    > diff --git a/drivers/net/ethernet/cirrus/ep93xx_eth.c b/drivers/net/ethernet/cirrus/ep93xx_eth.c
    > index 3a12c09..de9f7c9 100644
    > --- a/drivers/net/ethernet/cirrus/ep93xx_eth.c
    > +++ b/drivers/net/ethernet/cirrus/ep93xx_eth.c
    > @@ -475,8 +475,7 @@ static void ep93xx_free_buffers(struct ep93xx_priv *ep)
    > if (d)
    > dma_unmap_single(dev, d, PKT_BUF_SIZE, DMA_FROM_DEVICE);
    >
    > - if (ep->rx_buf[i] != NULL)
    > - kfree(ep->rx_buf[i]);
    > + kfree(ep->rx_buf[i]);
    > }
    >
    > for (i = 0; i < TX_QUEUE_ENTRIES; i++) {
    > @@ -486,8 +485,7 @@ static void ep93xx_free_buffers(struct ep93xx_priv *ep)
    > if (d)
    > dma_unmap_single(dev, d, PKT_BUF_SIZE, DMA_TO_DEVICE);
    >
    > - if (ep->tx_buf[i] != NULL)
    > - kfree(ep->tx_buf[i]);
    > + kfree(ep->tx_buf[i]);
    > }
    >
    > dma_free_coherent(dev, sizeof(struct ep93xx_descs), ep->descs,

    Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>

    Thanks


    \
     
     \ /
      Last update: 2015-02-04 17:41    [W:4.021 / U:0.128 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site