lkml.org 
[lkml]   [2015]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] net: Mellanox: Delete unnecessary checks before the function call "vunmap"
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Wed, 4 Feb 2015 15:17:00 +0100

    The vunmap() function performs also input parameter validation.
    Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/net/ethernet/mellanox/mlx4/alloc.c | 2 +-
    drivers/net/ethernet/mellanox/mlx5/core/alloc.c | 2 +-
    2 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/net/ethernet/mellanox/mlx4/alloc.c b/drivers/net/ethernet/mellanox/mlx4/alloc.c
    index 963dd7e..06faa51 100644
    --- a/drivers/net/ethernet/mellanox/mlx4/alloc.c
    +++ b/drivers/net/ethernet/mellanox/mlx4/alloc.c
    @@ -660,7 +660,7 @@ void mlx4_buf_free(struct mlx4_dev *dev, int size, struct mlx4_buf *buf)
    dma_free_coherent(&dev->pdev->dev, size, buf->direct.buf,
    buf->direct.map);
    else {
    - if (BITS_PER_LONG == 64 && buf->direct.buf)
    + if (BITS_PER_LONG == 64)
    vunmap(buf->direct.buf);

    for (i = 0; i < buf->nbufs; ++i)
    diff --git a/drivers/net/ethernet/mellanox/mlx5/core/alloc.c b/drivers/net/ethernet/mellanox/mlx5/core/alloc.c
    index 56779c1..201ca6d 100644
    --- a/drivers/net/ethernet/mellanox/mlx5/core/alloc.c
    +++ b/drivers/net/ethernet/mellanox/mlx5/core/alloc.c
    @@ -121,7 +121,7 @@ void mlx5_buf_free(struct mlx5_core_dev *dev, struct mlx5_buf *buf)
    dma_free_coherent(&dev->pdev->dev, buf->size, buf->direct.buf,
    buf->direct.map);
    else {
    - if (BITS_PER_LONG == 64 && buf->direct.buf)
    + if (BITS_PER_LONG == 64)
    vunmap(buf->direct.buf);

    for (i = 0; i < buf->nbufs; i++)
    --
    2.2.2


    \
     
     \ /
      Last update: 2015-02-04 15:41    [W:4.036 / U:0.148 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site