lkml.org 
[lkml]   [2015]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: linux-next: build failure after merge of the scsi tree
From
Date
(adding Christoph Hellwig)

On Wed, 2015-02-04 at 17:29 +1100, Stephen Rothwell wrote:
> Hi James,
>
> After merging the scsi tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> drivers/scsi/scsi_logging.c: In function 'sdev_prefix_printk':
> drivers/scsi/scsi_logging.c:119:6: error: void value not ignored as it ought to be
> ret = dev_printk(level, &sdev->sdev_gendev, "%s", logbuf);
> ^
> drivers/scsi/scsi_logging.c: In function 'scmd_printk':
> drivers/scsi/scsi_logging.c:146:6: error: void value not ignored as it ought to be
> ret = dev_printk(level, &scmd->device->sdev_gendev, "%s", logbuf);
> ^
>
> Caused by commit ded85c193a39 ("scsi: Implement per-cpu logging
> buffer") interacting with commit d1f1052c5204 ("device: Change
> dev_<level> logging functions to return void") from the driver-core
> tree.
>
> I added the following merge resolution patch. Someone will have to
> remember to tell Linus. Also, the void return may be able to be
> propagated further up the chain since these two new affected functions
> now always return 0.

Thanks and just so.

It seems that nothing uses either return value,
so it's probably better to use void for both
sdev_prefix_printk and scmd_printk.




\
 
 \ /
  Last update: 2015-02-04 08:01    [W:0.086 / U:1.340 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site