lkml.org 
[lkml]   [2015]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] net: fec: Delete unnecessary checks before the function call "kfree"
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Wed, 4 Feb 2015 12:56:42 +0100

    The kfree() function tests whether its argument is NULL and then
    returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/net/ethernet/freescale/fec_main.c | 7 ++-----
    1 file changed, 2 insertions(+), 5 deletions(-)

    diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
    index 1c7a7e4..29fd7e3 100644
    --- a/drivers/net/ethernet/freescale/fec_main.c
    +++ b/drivers/net/ethernet/freescale/fec_main.c
    @@ -2584,12 +2584,9 @@ static void fec_enet_free_queue(struct net_device *ndev)
    }

    for (i = 0; i < fep->num_rx_queues; i++)
    - if (fep->rx_queue[i])
    - kfree(fep->rx_queue[i]);
    -
    + kfree(fep->rx_queue[i]);
    for (i = 0; i < fep->num_tx_queues; i++)
    - if (fep->tx_queue[i])
    - kfree(fep->tx_queue[i]);
    + kfree(fep->tx_queue[i]);
    }

    static int fec_enet_alloc_queue(struct net_device *ndev)
    --
    2.2.2


    \
     
     \ /
      Last update: 2015-02-04 13:21    [W:4.018 / U:1.260 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site