lkml.org 
[lkml]   [2015]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] myri10ge: Delete an unnecessary check before the function call "kfree"
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Wed, 4 Feb 2015 12:32:14 +0100

    The kfree() function tests whether its argument is NULL and then
    returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/net/ethernet/myricom/myri10ge/myri10ge.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c b/drivers/net/ethernet/myricom/myri10ge/myri10ge.c
    index 71af98b..1412f5a 100644
    --- a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c
    +++ b/drivers/net/ethernet/myricom/myri10ge/myri10ge.c
    @@ -4226,8 +4226,7 @@ static void myri10ge_remove(struct pci_dev *pdev)
    mtrr_del(mgp->mtrr, mgp->iomem_base, mgp->board_span);
    #endif
    myri10ge_free_slices(mgp);
    - if (mgp->msix_vectors != NULL)
    - kfree(mgp->msix_vectors);
    + kfree(mgp->msix_vectors);
    dma_free_coherent(&pdev->dev, sizeof(*mgp->cmd),
    mgp->cmd, mgp->cmd_bus);

    --
    2.2.2


    \
     
     \ /
      Last update: 2015-02-04 12:41    [W:6.547 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site