Messages in this thread | | | Date | Tue, 03 Feb 2015 19:01:08 -0500 | From | Sasha Levin <> | Subject | Re: [PATCH v11 18/19] module: fix types of device tables aliases |
| |
On 02/03/2015 06:51 PM, Andrew Morton wrote: > From: Andrew Morton <akpm@linux-foundation.org> > Subject: MODULE_DEVICE_TABLE: fix some callsites > > The patch "module: fix types of device tables aliases" newly requires that > invokations of invocations > > MODULE_DEVICE_TABLE(type, name); > > come *after* the definition of `name'. That is reasonable, but some > drivers weren't doing this. Fix them. > > Cc: James Bottomley <James.Bottomley@HansenPartnership.com> > Cc: Andrey Ryabinin <a.ryabinin@samsung.com> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org> > --- > > drivers/scsi/be2iscsi/be_main.c | 1 - > 1 file changed, 1 deletion(-) > > diff -puN drivers/scsi/be2iscsi/be_main.c~module_device_table-fix-some-callsites drivers/scsi/be2iscsi/be_main.c > --- a/drivers/scsi/be2iscsi/be_main.c~module_device_table-fix-some-callsites > +++ a/drivers/scsi/be2iscsi/be_main.c > @@ -48,7 +48,6 @@ static unsigned int be_iopoll_budget = 1 > static unsigned int be_max_phys_size = 64; > static unsigned int enable_msix = 1; > > -MODULE_DEVICE_TABLE(pci, beiscsi_pci_id_table); > MODULE_DESCRIPTION(DRV_DESC " " BUILD_STR); > MODULE_VERSION(BUILD_STR); > MODULE_AUTHOR("Emulex Corporation");
This just removes MODULE_DEVICE_TABLE() rather than moving it to after the definition of beiscsi_pci_id_table.
Thanks, Sasha
| |