lkml.org 
[lkml]   [2015]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1] clk: qcom: Add MSM8916 Global Clock Controller support
Hi Georgi,

On 02/24/2015 09:19 PM, Georgi Djakov wrote:
> On 02/24/2015 06:49 AM, Archit Taneja wrote:
>> Hi,
> [..]
>>> +
>>> +static struct freq_tbl ftbl_gcc_mdss_pclk[] = {
>>> + { .src = P_DSI0_PHYPLL_DSI },
>>> + { }
>>> +};
>>> +
>>> +static struct clk_rcg2 pclk0_clk_src = {
>>> + .cmd_rcgr = 0x4d084,
>>
>> This should be 0x4d000. Same reason as above.
>>
>>> + .mnd_width = 8,
>>> + .hid_width = 5,
>>> + .parent_map = gcc_xo_gpll0_dsiphy_map,
>>> + .freq_tbl = ftbl_gcc_mdss_pclk,
>>> + .clkr.hw.init = &(struct clk_init_data){
>>> + .name = "pclk0_clk_src",
>>> + .parent_names = gcc_xo_gpll0_dsiphy,
>>> + .num_parents = 1,
>>> + .ops = &clk_rcg2_ops,
>>> + },
>>> +};
>>> +
>>> +static const struct freq_tbl ftbl_gcc_mdss_vsync_clk[] = {
>>> + F(19200000, P_XO, 1, 0, 0),
>>> + { }
>>> +};
>>> +
>>> +static struct clk_rcg2 vsync_clk_src = {
>>> + .cmd_rcgr = 0x4d02c,
>>> + .hid_width = 5,
>>> + .parent_map = gcc_xo_gpll0a_map,
>>> + .freq_tbl = ftbl_gcc_mdss_vsync_clk,
>>> + .clkr.hw.init = &(struct clk_init_data){
>>> + .name = "vsync_clk_src",
>>> + .parent_names = gcc_xo_gpll0a,
>>> + .num_parents = 2,
>>> + .ops = &clk_rcg2_ops,
>>> + },
>>> +};
>>> +
>>

I think we can update the clk ops for pclk0_clk_src and byte0_clk_src to
clk_pixel_ops and clk_byte_ops respectively too. The set_rate functions
in these ops have been modified to make it run with DSI PLL.

An Ack by Stephen for this change would be nice, though.

Archit

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project


\
 
 \ /
  Last update: 2015-02-25 14:21    [W:0.047 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site