lkml.org 
[lkml]   [2015]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] iommu/io-pgtable-arm: fix self-test WARNs on i386
On Mon, Feb 16, 2015 at 06:38:20PM +0000, Will Deacon wrote:
> Various build/boot bots have reported WARNs being triggered by the ARM
> iopgtable LPAE self-tests on i386 machines.
>
> This boils down to two instances of right-shifting a 32-bit unsigned
> long (i.e. an iova) by more than the size of the type. On 32-bit ARM,
> this happens to give us zero, hence my testing didn't catch this
> earlier.
>
> This patch fixes the issue by using DIV_ROUND_UP and explicit case to
> to avoid the erroneous shifts.
>
> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
> Reported-by: Huang Ying <ying.huang@intel.com>
> Signed-off-by: Will Deacon <will.deacon@arm.com>
> ---
>
> Joerg -- please can you apply this as a fix for 3.20?

Applied to my fixes branch, thanks Will.



\
 
 \ /
  Last update: 2015-02-25 14:01    [W:0.037 / U:6.136 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site