Messages in this thread | | | Date | Tue, 24 Feb 2015 06:16:58 +0100 | From | Oleksij Rempel <> | Subject | Re: [PATCH] clockevents: asm9260: Fix compilation error with sparc/sparc64 allyesconfig |
| |
Am 23.02.2015 um 22:21 schrieb Daniel Lezcano: > On 02/23/2015 09:46 PM, Oleksij Rempel wrote: >> Am 23.02.2015 um 21:34 schrieb Guenter Roeck: >>> On Mon, Feb 23, 2015 at 09:27:01PM +0100, Oleksij Rempel wrote: >>>> Am 23.02.2015 um 20:10 schrieb Guenter Roeck: >>>>> On Mon, Feb 23, 2015 at 08:00:51PM +0100, Daniel Lezcano wrote: >>>>>> The Kconfig options for the asm9260 timer is wrong as it can be >>>>>> selected by >>>>>> another platform with allyes config and thus leading to a >>>>>> compilation failure >>>>>> as some non arch related code is pulled by the compilation. >>>>>> >>>>>> Fix this by having the platform Kconfig to select the timer as it >>>>>> is done for >>>>>> the others drivers. >>>>>> >>>>>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> >>>>> >>>>> Acked-by: Guenter Roeck <linux@roeck-us.net> >>>>> >>>> >>>> the thing is, this SoC or this company has no own IP cores. All of them >>>> are from other companies and providers, including this timer. This is >>>> why all modules for this SoC are selectable. >>>> >>> Maybe the modules should be selected by the architectures using the >>> IP cores ? >> >> At the moment of pushing patches to arch/arm, maintainers preferred to >> have minimalistic Kconfig. >> >>> Either case, we'll need _some_ fix upstream, whatever is acceptable >>> for the >>> maintainer. >> >> What is with initial white list patch? > > The Kconfig policy for the timers is to let the arch to select the timer > they need and not enable them from the clocksource/Kconfig file. That is > the general policy even there are a couple of exceptions. > > So if you are ok with the patch I sent I will merge it as a fix. > >
I'm ok with it. Thank you, for your work.
-- Regards, Oleksij
[unhandled content-type:application/pgp-signature] | |