lkml.org 
[lkml]   [2015]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: fs: dax: do not build on ARC or SH
On Mon, Feb 23, 2015 at 01:58:47PM -0800, Christoph Hellwig wrote:
> On Mon, Feb 23, 2015 at 01:56:34PM -0800, Guenter Roeck wrote:
> > Guess there a philosophical difference in opinion if the architecture code
> > should (have to) provide copy_user_page() or not outside the architecture
> > code itself. After all, fs/dax.c _is_ the only user of this function outside
> > the architecture code.
>
> Given that copy_user_page just is an optimized version of copy_page
> all these architectures should just grab the trivial macro defintion
> from the asm-generic version so that we could avoid this discussion.
>
I tried to do just that, for mips, with little success.

https://patchwork.linux-mips.org/patch/9175/

Presumably, if copy_page() followed by a conditional flush_data_cache_page()
does not work on mips, I would assume that copy_page() without flush does not
work either.

Guenter


\
 
 \ /
  Last update: 2015-02-23 23:21    [W:0.034 / U:0.668 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site