lkml.org 
[lkml]   [2015]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 06/27] power: wakeup: Remove use of seq_printf return value
From
Date
On Sun, 2015-02-22 at 22:38 +0100, Pavel Machek wrote:
> On Sat 2015-02-21 18:53:33, Joe Perches wrote:
> > The seq_printf return value, because it's frequently misused,
> > will eventually be converted to void.
> >
> > See: commit 1f33c41c03da ("seq_file: Rename seq_overflow() to
> > seq_has_overflowed() and make public")
>
> You've just removed overflow handling from
> print_wakeup_source_stats.
>
> Can you explain why that is good idea?

If overflow occurs, the seq_file subsystem allocates
a bigger buffer and calls the show function again.

See Al's comment in the 0/n patch and here:
https://lkml.org/lkml/2015/2/17/642




\
 
 \ /
  Last update: 2015-02-22 23:01    [W:0.154 / U:1.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site