lkml.org 
[lkml]   [2015]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 27/35] sched/idle: Use explicit broadcast oneshot control function
On Fri, Feb 20, 2015 at 07:56:17PM -0500, Nicolas Pitre wrote:
> On Mon, 16 Feb 2015, Peter Zijlstra wrote:
>
> > From: Thomas Gleixner <tglx@linutronix.de>
> >
> > Replace the clockevents_notify() call with an explicit function call.
> >
> > Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
>
> This patch makes my test system hang solid after letting it sit idle for
> 5 to 15 minutes. Reverting it and this issue goes away.
>
> The explicit function call is not an equivalent replacement. In
> clockevents_notify() the clockevents_lock is held across the call to
> tick_broadcast_enter() or tick_broadcast_exit(). This patch drops the
> locking.

Yeah, the Changelog introducing the explicit call states as much. I'll
have to go figure out why that matters here.


\
 
 \ /
  Last update: 2015-02-21 12:41    [W:0.468 / U:0.308 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site