lkml.org 
[lkml]   [2015]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [GIT PULL] locking fixes

* Ingo Molnar <mingo@kernel.org> wrote:

> ( I've attached the build log that I saw before sending you
> the pull request. )
>
> The kbuild test robot which tests for warnings didn't
> report one to me either. I tested a few other configs as
> well:
>
> x86 defconfig (PARAVIRT=n): 0 warnings
> 'make kvmconfig' (PARAVIRT=y): 0 warnings
> x86 bootable config (attached): 0 warnings

Oh, crap, I just triggered the warnings with:

x86 defconfig + 'make kvmconfig' + CONFIG_PARAVIRT_SPINLOCKS=y.

My bad, mea culpa ...

I just tested your patch.diff and it fixed the warnings:

Tested-by: Ingo Molnar <mingo@kernel.org>

Extra sad: I _did_ build and boot test paravirt spinlocks
as well, but only within a test environment that does not
show warnings (in general there's too many of them, even
defconfig is rarely warnings free, although it is with the
very latest kernel) and my burn-in test before the pull
request didn't have paravirt spinlocks turned on.

But you do allmodconfig tests and look at warnings so there
it probably showed up straight away?

Thanks,

Ingo


\
 
 \ /
  Last update: 2015-02-21 06:41    [W:0.074 / U:1.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site