Messages in this thread | | | Subject | Re: [PATCH 4/4] Staging: rtl8192u: r819xU_firmware: added space after comma | From | Joe Perches <> | Date | Fri, 20 Feb 2015 17:59:37 -0800 |
| |
On Fri, 2015-02-20 at 16:31 -0800, Tolga Ceylan wrote: > On Fri, Feb 20, 2015 at 11:47 AM, Tolga Ceylan <tolga.ceylan@gmail.com> wrote: > > On Thu, Feb 19, 2015 at 11:30 PM, Joe Perches <joe@perches.com> wrote: > >> Might as well remove the unnecessary cast too: > >> memcpy(skb->cb, &dev, sizeof(dev)); > >> but it might be better to avoid the memcpy and use an assign > >> *(struct net_device *)skb->cb = dev; [] > Should I sent a new set of patches (including memcpy change)? > Or reply to the series with a single memcpy change patch?
Let Larry Finger decide if he wants the patches at all first.
| |