Messages in this thread | | | From | Andy Lutomirski <> | Date | Fri, 20 Feb 2015 11:27:39 -0800 | Subject | Re: [PATCH 6/7] thinkpad_acpi: More Carbon X1 2014 keys |
| |
On 02/20/2015 06:44 AM, Bastien Nocera wrote: > + KEY_MICCANCEL_MODE, /* Microphone cancellation */
What's this? We already have KEY_MICMUTE. Is this different? If so, can you improve the comment a bit?
The answer may be obvious to anyone who has an awful X1 carbon gen 2 keyboard, but these KEY_XYZ defines should IMO be clear enough that even people without the hardware can figure out what's going on.
--Andy
| |