lkml.org 
[lkml]   [2015]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 6/7] thinkpad_acpi: More Carbon X1 2014 keys
On 02/20/2015 06:44 AM, Bastien Nocera wrote:
> + KEY_MICCANCEL_MODE, /* Microphone cancellation */

What's this? We already have KEY_MICMUTE. Is this different? If so,
can you improve the comment a bit?

The answer may be obvious to anyone who has an awful X1 carbon gen 2
keyboard, but these KEY_XYZ defines should IMO be clear enough that even
people without the hardware can figure out what's going on.

--Andy


\
 
 \ /
  Last update: 2015-02-20 21:01    [W:0.045 / U:0.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site