Messages in this thread | | | Date | Fri, 20 Feb 2015 11:18:09 -0800 | From | David Cohen <> | Subject | Re: [PATCH v2] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s) |
| |
On Fri, Feb 20, 2015 at 08:10:34PM +0100, Paul Bolle wrote: > On Fri, 2015-02-20 at 11:02 -0800, David Cohen wrote: > > On Thu, Feb 19, 2015 at 11:39:06PM +0100, Paul Bolle wrote: > > > On Thu, 2015-02-19 at 11:59 -0800, David Cohen wrote: > > > > As always, comments are welcome. > > > > > > Are nits welcome too? > > > > > > > +MODULE_LICENSE("GPLv2"); > > > > > > You probably meant > > > MODULE_LICENSE("GPL v2") > > > > > > Didn't that trigger a warning or error? > > > > checkpatch showed no warning about that, not even with --strict option. > > I believe both ways are fine. But I can add the space. > > "GPLv2" is not mentioned in include/linux/license.h so, as I remember, > it would taint the kernel, and a warning will be printed when you load > that module.
Ack :) I'll add a space on next version.
Br, David
> > Thanks, > > > Paul Bolle >
| |