Messages in this thread | | | Date | Fri, 20 Feb 2015 19:53:19 +0100 | From | Jiri Olsa <> | Subject | Re: [PATCH] perf: Only include tsc file for x86 |
| |
On Fri, Feb 20, 2015 at 09:40:57AM -0700, David Ahern wrote: > On 2/20/15 1:36 AM, Adrian Hunter wrote: > >On 19/02/15 21:42, Jiri Olsa wrote: > >>On Thu, Feb 19, 2015 at 01:22:33PM -0500, David Ahern wrote: > >>>perf_time_to_tsc and tsc_to_perf_time are only used for x86. Make > >>>inclusion of tsc.c dependent on x86 as well. > >> > >>hum, should we move it to arch/x86/util/tsc.c and remove util/tsc.c? > > > >It is not arch-specific because you can read a perf.data file > >from one architecture on another architecture. > > > >The TSC stuff was planned for Intel PT although it might now > >be done differently. > > > >Probably you should have CONFIG_X86_TSC and then select that > >with CONFIG_X86. Later it can be selected with CONFIG_INTEL_PT > >as well. > > For now let's leave it as CONFIG_X86. Right now only X86 code needs the > functions it provides and there is no need taking any other steps until > something is going to use it. > > ie., patch is good as is. Agreed?
ook, jirka
| |