lkml.org 
[lkml]   [2015]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3/7 linux-next] powerpc/pmac: replace current->state by set_current_state()
    Date
    Use helper functions to access current->state.
    Direct assignments are prone to races and therefore buggy.

    current->state = TASK_RUNNING can be replaced by __set_current_state()

    Thanks to Peter Zijlstra for the exact definition of the problem.

    Suggested-By: Peter Zijlstra <peterz@infradead.org>
    Signed-off-by: Fabian Frederick <fabf@skynet.be>
    ---
    drivers/macintosh/via-pmu.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/macintosh/via-pmu.c b/drivers/macintosh/via-pmu.c
    index dee88e5..3c608d4 100644
    --- a/drivers/macintosh/via-pmu.c
    +++ b/drivers/macintosh/via-pmu.c
    @@ -2109,7 +2109,7 @@ pmu_read(struct file *file, char __user *buf,

    spin_lock_irqsave(&pp->lock, flags);
    add_wait_queue(&pp->wait, &wait);
    - current->state = TASK_INTERRUPTIBLE;
    + set_current_state(TASK_INTERRUPTIBLE);

    for (;;) {
    ret = -EAGAIN;
    @@ -2138,7 +2138,7 @@ pmu_read(struct file *file, char __user *buf,
    schedule();
    spin_lock_irqsave(&pp->lock, flags);
    }
    - current->state = TASK_RUNNING;
    + __set_current_state(TASK_RUNNING);
    remove_wait_queue(&pp->wait, &wait);
    spin_unlock_irqrestore(&pp->lock, flags);

    --
    2.1.0


    \
     
     \ /
      Last update: 2015-02-20 19:21    [W:4.098 / U:0.832 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site