lkml.org 
[lkml]   [2015]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFT PATCH v2 2/2] compal-laptop: Check return value of power_supply_register
From
Date
On pią, 2015-02-20 at 14:04 +0100, Krzysztof Kozlowski wrote:
> The return value of power_supply_register() call was not checked and
> even on error probe() function returned 0. If registering failed then
> during unbind the driver tried to unregister power supply which was not
> actually registered.
>
> This could lead to memory corruption because power_supply_unregister()
> unconditionally cleans up given power supply.
>
> Fix this by checking return status of power_supply_register() call. In
> case of failure, clean up sysfs entries and fail the probe.
>

(...)

>
> @@ -1072,6 +1074,7 @@ static int compal_remove(struct platform_device *pdev)
>
> data = platform_get_drvdata(pdev);
> power_supply_unregister(&data->psy);
> + /* FIXME: missing hwmon_device_unregister() */
>
> sysfs_remove_group(&pdev->dev.kobj, &compal_platform_attr_group);


Crap, I forgot to remove the FIXME note. It is no longer needed because
patch 1 fixes this.

I'll resend. Sorry for the noise.





\
 
 \ /
  Last update: 2015-02-20 14:21    [W:0.030 / U:0.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site