Messages in this thread Patch in this message | | | From | Rasmus Villemoes <> | Subject | [PATCH 1/5] mm/internal.h: Don't split printk call in two | Date | Tue, 3 Feb 2015 00:50:12 +0100 |
| |
All users of mminit_dprintk pass a compile-time constant as level, so this just makes gcc emit a single printk call instead of two.
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> ---
Notes: Not a huge deal, since the only users are __init or __meminit functions, but even there saving 140 bytes may be worthwhile.
mm/internal.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/mm/internal.h b/mm/internal.h index efad241f7014..e1d8e05bcfff 100644 --- a/mm/internal.h +++ b/mm/internal.h @@ -329,8 +329,10 @@ extern int mminit_loglevel; #define mminit_dprintk(level, prefix, fmt, arg...) \ do { \ if (level < mminit_loglevel) { \ - printk(level <= MMINIT_WARNING ? KERN_WARNING : KERN_DEBUG); \ - printk(KERN_CONT "mminit::" prefix " " fmt, ##arg); \ + if (level <= MMINIT_WARNING) \ + printk(KERN_WARNING "mminit::" prefix " " fmt, ##arg); \ + else \ + printk(KERN_DEBUG "mminit::" prefix " " fmt, ##arg); \ } \ } while (0) -- 2.1.3
| |