lkml.org 
[lkml]   [2015]   [Feb]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2] ARM: pxa: fix pxa interrupts handling in DT
Date
Robert Jarzmik <robert.jarzmik@free.fr> writes:

> @@ -66,18 +67,20 @@ static inline void __iomem *irq_base(int i)
> void pxa_mask_irq(struct irq_data *d)
> {
> void __iomem *base = irq_data_get_irq_chip_data(d);
> + irq_hw_number_t irq = irqd_to_hwirq(d);
> uint32_t icmr = __raw_readl(base + ICMR);
>
> - icmr &= ~(1 << IRQ_BIT(d->irq));
> + icmr &= ~BIT(irq);
This should be : icmr &= ~BIT(irq & 0x1f);

> __raw_writel(icmr, base + ICMR);
> }
>
> void pxa_unmask_irq(struct irq_data *d)
> {
> void __iomem *base = irq_data_get_irq_chip_data(d);
> + irq_hw_number_t irq = irqd_to_hwirq(d);
> uint32_t icmr = __raw_readl(base + ICMR);
>
> - icmr |= 1 << IRQ_BIT(d->irq);
> + icmr |= BIT(irq);
Ditto.

> +void __init pxa_init_irq(int irq_nr, int (*fn)(struct irq_data *, unsigned int))
> +{
> + BUG_ON(irq_nr > MAX_INTERNAL_IRQS);
> +
> + pxa_irq_base = io_p2v(0x40d00000);
> + cpu_has_ipr = !cpu_is_pxa25x();
> + pxa_init_irq_common(NULL, irq_nr, fn);
> +}
This requires "select IRQ_DOMAIN" in arch/arm/Kconfig in ARCH_PXA.

--
Robert


\
 
 \ /
  Last update: 2015-02-02 21:41    [W:0.054 / U:0.388 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site