lkml.org 
[lkml]   [2015]   [Feb]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] EDAC: Deletion of unnecessary checks before the function call "pci_dev_put"
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Mon, 2 Feb 2015 18:26:34 +0100

    The pci_dev_put() function tests whether its argument is NULL and then
    returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/edac/i82443bxgx_edac.c | 4 +---
    drivers/edac/i82860_edac.c | 9 ++-------
    drivers/edac/i82875p_edac.c | 4 +---
    drivers/edac/i82975x_edac.c | 4 +---
    4 files changed, 5 insertions(+), 16 deletions(-)

    diff --git a/drivers/edac/i82443bxgx_edac.c b/drivers/edac/i82443bxgx_edac.c
    index b4705d9..38d6406 100644
    --- a/drivers/edac/i82443bxgx_edac.c
    +++ b/drivers/edac/i82443bxgx_edac.c
    @@ -445,9 +445,7 @@ fail1:
    pci_unregister_driver(&i82443bxgx_edacmc_driver);

    fail0:
    - if (mci_pdev != NULL)
    - pci_dev_put(mci_pdev);
    -
    + pci_dev_put(mci_pdev);
    return pci_rc;
    }

    diff --git a/drivers/edac/i82860_edac.c b/drivers/edac/i82860_edac.c
    index 4382343..ee1078c 100644
    --- a/drivers/edac/i82860_edac.c
    +++ b/drivers/edac/i82860_edac.c
    @@ -343,20 +343,15 @@ fail1:
    pci_unregister_driver(&i82860_driver);

    fail0:
    - if (mci_pdev != NULL)
    - pci_dev_put(mci_pdev);
    -
    + pci_dev_put(mci_pdev);
    return pci_rc;
    }

    static void __exit i82860_exit(void)
    {
    edac_dbg(3, "\n");
    -
    pci_unregister_driver(&i82860_driver);
    -
    - if (mci_pdev != NULL)
    - pci_dev_put(mci_pdev);
    + pci_dev_put(mci_pdev);
    }

    module_init(i82860_init);
    diff --git a/drivers/edac/i82875p_edac.c b/drivers/edac/i82875p_edac.c
    index 64b6832..c26a513 100644
    --- a/drivers/edac/i82875p_edac.c
    +++ b/drivers/edac/i82875p_edac.c
    @@ -576,9 +576,7 @@ fail1:
    pci_unregister_driver(&i82875p_driver);

    fail0:
    - if (mci_pdev != NULL)
    - pci_dev_put(mci_pdev);
    -
    + pci_dev_put(mci_pdev);
    return pci_rc;
    }

    diff --git a/drivers/edac/i82975x_edac.c b/drivers/edac/i82975x_edac.c
    index 10b1052..35ab66c 100644
    --- a/drivers/edac/i82975x_edac.c
    +++ b/drivers/edac/i82975x_edac.c
    @@ -685,9 +685,7 @@ fail1:
    pci_unregister_driver(&i82975x_driver);

    fail0:
    - if (mci_pdev != NULL)
    - pci_dev_put(mci_pdev);
    -
    + pci_dev_put(mci_pdev);
    return pci_rc;
    }

    --
    2.2.2


    \
     
     \ /
      Last update: 2015-02-02 19:41    [W:4.021 / U:0.168 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site